Messages in this thread | | | Date | Wed, 08 Oct 2014 15:45:13 -0400 (EDT) | Subject | Re: [PATCH net-next] r8152: use mutex for hw settings | From | David Miller <> |
| |
From: Hayes Wang <hayeswang@realtek.com> Date: Tue, 7 Oct 2014 13:36:30 +0800
> Use mutex to avoid that the serial hw settings would be interrupted > by other settings. Although there is no problem now, it makes the > driver more safe. > > Signed-off-by: Hayes Wang <hayeswang@realtek.com>
I think a much simpler fix is to take rtnl_lock() in the workqueue function and suspend/resume ops.
Every other place you are adding the mutex already holds the RTNL mutex.
| |