Messages in this thread | | | Date | Wed, 08 Oct 2014 12:42:24 -0400 | From | Rik van Riel <> | Subject | Re: [PATCH] sched/fair: Care divide error in update_task_scan_period() |
| |
On 10/08/2014 02:43 AM, Yasuaki Ishimatsu wrote:
> The divide error is rare case because the trigger is node offline. > By this patch, when both of private and shared are set to 0, diff > is just set to 0, not calculating the division.
How about a simple
if (private + shared) == 0) return;
higher up in the function, to avoid adding an extra layer of indentation and confusion to the main part of the function?
| |