Messages in this thread | | | Date | Wed, 8 Oct 2014 11:06:31 -0500 | From | Josh Cartwright <> | Subject | Re: [PATCH 2/4] ARM: qcom: add description of KPSS WDT for IPQ8064 |
| |
On Tue, Oct 07, 2014 at 04:07:43PM -0700, Stephen Boyd wrote: > On 10/07/2014 03:10 PM, Josh Cartwright wrote: > >On Thu, Oct 02, 2014 at 12:08:38PM -0700, Stephen Boyd wrote: [..] > >>I'm thinking: > >> > >> timer@200a000 { > >> compatible = "qcom,kpss-timer", "qcom,msm-timer"; > >> interrupts = <1 1 0x301>, > >> <1 2 0x301>, > >> <1 3 0x301>, > >> <1 4 0x301>, > >> <1 5 0x301>; > >> reg = <0x0200a000 0x100>; > >> clock-frequency = <27000000>, > >> <32768>; > >> clocks = <&cxo>, <&sleep_clk>; > >> clock-names = "ref", "sleep"; > >> cpu-offset = <0x80000>; > >> }; > >Where'd the default timeout configuration go? Or, should we have one > >timeout-sec property and not allow setting the default timeouts per WDT > >instance? Or no configurable timeout at all? > > Ah sorry. How about a timeout-sec-0, timeout-sec-1 property that is per-cpu > and maps to the first and second watchdog timer? Something like: > > timeout-sec-wdt0 = <10 8>; > timeout-sec-wdt1 = <20 15>;
Okay, yeah, this is much more concise. I'll take a stab at implementing it.
Thanks, Josh
-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
| |