Messages in this thread | | | Date | Wed, 08 Oct 2014 16:02:49 +0200 | From | Bart Tanghe <> | Subject | Re: [PATCH v7]pwm: add BCM2835 PWM driver |
| |
On 2014-10-08 14:19, Thierry Reding wrote: > On Wed, Oct 08, 2014 at 12:14:32PM +0200, Bart Tanghe wrote: >> Add pwm driver for Broadcom BCM2835 processor (Raspberry Pi) >> >> Signed-off-by: Bart Tanghe <bart.tanghe@thomasmore.be> >> --- >> Changed in v7: >> - clean up the shameful clk_enable error handling introduced in v6 >> - clean up the code nits >> >> diff --git a/Documentation/devicetree/bindings/pwm/pwm-bcm2835.txt b/Documentation/devicetree/bindings/pwm/pwm-bcm2835.txt >> new file mode 100644 >> index 0000000..d5162db >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pwm/pwm-bcm2835.txt >> @@ -0,0 +1,27 @@ >> +BCM2835 PWM controller (Raspberry Pi controller) >> + >> +Required properties: >> +- compatible: should be "brcm,bcm2835-pwm" >> +- reg: physical base address and length of the controller's registers >> +- clock: this clock defines the base clock frequency of the pwm >> +hardware system, the period and the duty_cycle of the pwm signal is a >> +multiple of the base period > > This needs to document the #pwm-cells property. I can fix that up when > applying, though. > > Let's give Stephen and others a chance to give this another look. > > Thierry > Perfect, thanks.
Bart
| |