Messages in this thread | | | Date | Wed, 8 Oct 2014 15:55:45 +0530 | Subject | Re: [PATCH] Input: adp5588-keys: cancel workqueue in failure path | From | Pramod Gurav <> |
| |
On Wed, Oct 8, 2014 at 3:48 PM, Pramod Gurav <pramod.gurav.etc@gmail.com> wrote: > Hi Dmitry, > > On Tue, Oct 7, 2014 at 10:08 PM, Dmitry Torokhov >
..
> Thanks. I saw the change in your tree. Shouldn't > cancel_delayed_work_sync(&kpad->work) be called under label > err_free_mem so that it will executed in case adp5588_read, > input_register_device, request_irq etc. > Or else we will still have workqueue instance hanging around. >
Sorry, Should have read Michael's reply more carefully. I get the reason behind cancelling workquequq after freeing irq.
-- Thanks and Regards Pramod
| |