Messages in this thread | | | From | Dexuan Cui <> | Subject | RE: [PATCH v3] Tools: hv: vssdaemon: ignore the EBUSY on multiple freezing the same partition | Date | Wed, 8 Oct 2014 05:23:52 +0000 |
| |
> -----Original Message----- > From: devel [mailto:driverdev-devel-bounces@linuxdriverproject.org] On Behalf > Of Dexuan Cui > Sent: Friday, September 26, 2014 12:52 PM > To: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org; driverdev- > devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com; > jasowang@redhat.com > Cc: Haiyang Zhang > Subject: [PATCH v3] Tools: hv: vssdaemon: ignore the EBUSY on multiple > freezing the same partition > > If a partition appears mounted more than once in /proc/mounts, vss_do_freeze() > succeeds only for the first time and gets EBUSY (on freeze) or EINVAL (on > thaw) for the second time. The patch ignores these to make the backup feature > work. > > Also improved the error handling in case a freeze operation fails. > > Signed-off-by: Dexuan Cui <decui@microsoft.com> > Reviewed-by: K. Y. Srinivasan <kys@microsoft.com> > --- > > v2: Add "errno = 0;" before the ioctl() > (Unnecessary and removed now since we remove syslog() in vss_do_freeze() in > v3) > > v3: Remove the unsafe syslog() in vss_do_freeze(): that could write the disk. > Thaw the filesystems in case the freezing operation fails. > In main(), add syslog() when we check the return value of vss_operate(). > > tools/hv/hv_vss_daemon.c | 48
Hi Greg, Ping.
Thanks, -- Dexuan
| |