Messages in this thread | | | From | "Opensource [Adam Thomson]" <> | Subject | RE: [PATCH 2/8] mfd: da9150: Add DT binding documentation for core | Date | Tue, 7 Oct 2014 13:47:01 +0000 |
| |
On September 27, 2014 11:37, Jonathan Cameron wrote:
> On 23/09/14 11:53, Adam Thomson wrote: > > Signed-off-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com> > Obviously this really wants a review from one of the device tree guys, but I > have a few > bits based on what Mark has recently said in other reviews ;) > > --- > > Documentation/devicetree/bindings/mfd/da9150.txt | 41 > ++++++++++++++++++++++++ > > 1 file changed, 41 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mfd/da9150.txt > > > > diff --git a/Documentation/devicetree/bindings/mfd/da9150.txt > b/Documentation/devicetree/bindings/mfd/da9150.txt > > new file mode 100644 > > index 0000000..d7de150 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mfd/da9150.txt > > @@ -0,0 +1,41 @@ > > +Dialog Semiconductor DA9150 Combined Charger/Fuel-Gauge MFD bindings > > + > > +DA9150 consists of a group of sub-devices (I2C Only): > What does I2C only add to the description?
Nothing really. Will remove.
> > + > > +Device Description > > +------ ----------- > > +da9150-gpadc : IIO - GPADC > Given usual aversion to anything driver specific in the device tree description > you probably > just want to describe what they do rather than what subsystem provides the driver.
Ok, can update accordingly.
> > > +da9150-charger : Power Supply (Charger) > > + > > +====== > > + > > +Required properties: > > +- compatible : Should be "dlg,da9150" > > +- reg: Specifies the I2C slave address > > +- interrupt-parent: Specifies the phandle of the interrupt controller to which > > + the IRQs from da9150 are delivered to. > > +- interrupts: IRQ line info for da9150 chip. > Cross refer to the standard interrupts doc for these... >
Ok, can do that.
> > +- interrupt-controller: da9150 has internal IRQs (own IRQ domain). > > + > > +Sub-devices: > > +- da9150-gpadc: See Documentation/devicetree/bindings/iio/adc/da9150- > gpadc.txt > > +- da9150-charger: See Documentation/devicetree/bindings/power/da9150- > charger.txt > > + > > + > > +Example: > > + > > + charger_fg: da9150@58 { > > + compatible = "dlg,da9150"; > > + reg = <0x58>; > > + interrupt-parent = <&gpio6>; > > + interrupts = <11 IRQ_TYPE_LEVEL_LOW>; > > + interrupt-controller; > > + > > + gpadc: da9150-gpadc { > > + ... > > + }; > > + > > + da9150-charger { > > + ... > > + }; > > + }; > > -- > > 1.9.3 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > >
| |