lkml.org 
[lkml]   [2014]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RESUBMIT PATCH v3 7/8] regulator: sky81452: Add compatible string for device binding
On Tue, Oct 07, 2014 at 02:11:07PM +0900, Gyungoh Yoo wrote:
> Signed-off-by: Gyungoh Yoo <jack.yoo@skyworksinc.com>

Several problems here:

- I don't have patches 1-6 or the cover letter for this series - what
are the dependencies?
- I can't see any sign that my concerns about the driver not actually
being reusable have been addressed here.
- This patch appears to do way more than add a compatible string, for
example:

> - np = of_get_child_by_name(dev->parent->of_node, "regulator");
> - if (unlikely(!np)) {
> + if (!np) {
> dev_err(dev, "regulator node not found");
> - return NULL;
> + return ERR_PTR(-ENODATA);
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-10-07 15:21    [W:0.286 / U:1.760 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site