Messages in this thread | | | Date | Tue, 7 Oct 2014 17:35:13 +0530 | From | Amit Shah <> | Subject | Re: [PATCH v2 01/15] virtio_pci: fix virtio spec compliance on restore |
| |
On (Mon) 06 Oct 2014 [18:10:40], Michael S. Tsirkin wrote: > On restore, virtio pci does the following: > + set features > + init vqs etc - device can be used at this point! > + set ACKNOWLEDGE,DRIVER and DRIVER_OK status bits > > This is in violation of the virtio spec, which > requires the following order: > - ACKNOWLEDGE > - DRIVER > - init vqs > - DRIVER_OK > > This behaviour will break with hypervisors that assume spec compliant > behaviour. It seems like a good idea to have this patch applied to > stable branches to reduce the support butden for the hypervisors. > > Cc: stable@vger.kernel.org > Cc: Amit Shah <amit.shah@redhat.com> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
I didn't see my previous questions answered from the initial posting -- can you please respond to them?
Amit
| |