Messages in this thread | | | Date | Tue, 7 Oct 2014 12:53:35 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 1/5] regulator: Add ena_gpio_valid config |
| |
On Mon, Oct 06, 2014 at 10:17:11PM +0200, Markus Pargmann wrote: > Most drivers do not set the ena_gpio field of struct regulator_config > before passing it to the regulator core. This is fine as long as the > gpio identifier that is passed is a positive integer. But the gpio > identifier 0 is also valid. So we are not able to decide wether we got a > real gpio identifier or not. > > To be able to decide if it is a valid gpio that got passed, this patch > adds a ena_gpio_valid field that should be set if ena_gpio is a valid > gpio and should be used. It is a preperation patch for multiple patches > that adapt the drivers and fix the regulator core checks for this field.
This should be part of the patch adding meaningful behaviour for the flag, it's pointless separately. [unhandled content-type:application/pgp-signature] | |