Messages in this thread | | | Subject | Re: [PATCH net-next] net: core: Quiet W=1 warnings for unused vars and static functions | From | Joe Perches <> | Date | Mon, 06 Oct 2014 15:04:24 -0700 |
| |
On Mon, 2014-10-06 at 17:56 -0400, David Miller wrote: > From: Joe Perches <joe@perches.com> > Date: Mon, 06 Oct 2014 14:51:38 -0700 > > > Reduce noise when compiling W=1. [] > BTW, this patch reminds me that if people think there are > subdirectories where we can turn on things like -Werror in the > networking I would be very happy to apply such patches. [] > Things like net/core/ for example should be doable for sure.
I don't have any significant opposition to -Werror, but I think there are real arguments _against_ using -Werror.
I think the primary one is new compiler versions have a tendency to add new warnings for various things that can unnecessarily and unpredictably break the build.
| |