Messages in this thread | | | Subject | Re: [PATCH net-next] net: core: Quiet W=1 warnings for unused vars and static functions | From | Eric Dumazet <> | Date | Mon, 06 Oct 2014 15:02:19 -0700 |
| |
On Mon, 2014-10-06 at 14:51 -0700, Joe Perches wrote: > Reduce noise when compiling W=1. > > All the variables are unused. > The functions are not called outside of the file so static > is preferred. > > Signed-off-by: Joe Perches <joe@perches.com> > --- > > John, can you please verify that these gen_stats accesses > are unnecessary? I believe the compiler can elide them in > any case, but I'm not sure what you intended here.
...
> diff --git a/net/core/gen_stats.c b/net/core/gen_stats.c > index 14681b9..01be9cf 100644 > --- a/net/core/gen_stats.c > +++ b/net/core/gen_stats.c > @@ -106,13 +106,9 @@ __gnet_stats_copy_basic_cpu(struct gnet_stats_basic_packed *bstats, > for_each_possible_cpu(i) { > struct gnet_stats_basic_cpu *bcpu = per_cpu_ptr(cpu, i); > unsigned int start; > - __u64 bytes; > - __u32 packets; > > do { > start = u64_stats_fetch_begin_irq(&bcpu->syncp); > - bytes = bcpu->bstats.bytes; > - packets = bcpu->bstats.packets; > } while (u64_stats_fetch_retry_irq(&bcpu->syncp, start)); >
Well... Please fix the bug for real.
> bstats->bytes += bcpu->bstats.bytes;
->
bstats->bytes += bytes; bstats->packets += packets;
| |