lkml.org 
[lkml]   [2014]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V5 08/13] sched: add a macro to ref all CLONE_NEW* flags
On 14/10/06, Chen, Hanxiao wrote:
>
>
> > -----Original Message-----
> > From: containers-bounces@lists.linux-foundation.org
> > [mailto:containers-bounces@lists.linux-foundation.org] On Behalf Of Richard Guy
> > Briggs
> > Sent: Monday, October 06, 2014 1:09 PM
> > To: linux-audit@redhat.com; linux-kernel@vger.kernel.org;
> > containers@lists.linux-foundation.org
> > Cc: eparis@redhat.com; pmoore@redhat.com; aviro@redhat.com; sgrubb@redhat.com;
> > ebiederm@xmission.com
> > Subject: [PATCH V5 08/13] sched: add a macro to ref all CLONE_NEW* flags
> >
> > ---
> > include/uapi/linux/sched.h | 6 ++++++
> > 1 files changed, 6 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/uapi/linux/sched.h b/include/uapi/linux/sched.h
> > index 34f9d73..5aceba2 100644
> > --- a/include/uapi/linux/sched.h
> > +++ b/include/uapi/linux/sched.h
> > @@ -28,6 +28,12 @@
> > #define CLONE_NEWUSER 0x10000000 /* New user namespace */
> > #define CLONE_NEWPID 0x20000000 /* New pid namespace */
> > #define CLONE_NEWNET 0x40000000 /* New network namespace */
> > +#define CLONE_NEW_MASK ( CLONE_NEWNS \
> > + | CLONE_NEWUTS \
> > + | CLONE_NEWIPC \
> > + | CLONE_NEWUSER \
> > + | CLONE_NEWPID \
> > + | CLONE_NEWNET) /* mask of all namespace type flags */
> > #define CLONE_IO 0x80000000 /* Clone io context */
>
> The name 'CLONE_NEW_MASK' may confuse readers.
> How about something like CLONE_NEW_MASK_ALL?

Fair enough. Changed.

> Thanks,
> - Chen

- RGB

--
Richard Guy Briggs <rbriggs@redhat.com>
Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat
Remote, Ottawa, Canada
Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545


\
 
 \ /
  Last update: 2014-10-06 15:21    [W:0.110 / U:0.564 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site