lkml.org 
[lkml]   [2014]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 13/16] virtio_blk: enable VQs early
    virtio spec requires drivers to set DRIVER_OK before using VQs.
    This is set automatically after probe returns, virtio block violated this
    rule by calling add_disk, which causes the VQ to be used directly within
    probe.

    To fix, call virtio_early_enable_vqs before using VQs.

    Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    ---
    drivers/block/virtio_blk.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
    index 13c384b..e59ae859 100644
    --- a/drivers/block/virtio_blk.c
    +++ b/drivers/block/virtio_blk.c
    @@ -719,6 +719,8 @@ static int virtblk_probe(struct virtio_device *vdev)
    if (!err && opt_io_size)
    blk_queue_io_opt(q, blk_size * opt_io_size);

    + virtio_early_enable_vqs(vdev);
    +
    add_disk(vblk->disk);
    err = device_create_file(disk_to_dev(vblk->disk), &dev_attr_serial);
    if (err)
    --
    MST


    \
     
     \ /
      Last update: 2014-10-05 18:42    [W:2.716 / U:0.344 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site