Messages in this thread | | | Date | Sun, 5 Oct 2014 11:47:34 -0700 | From | "Paul E. McKenney" <> | Subject | Re: [PATCH v2 2/2] workqueue: use cond_resched_rcu_qs macro |
| |
On Sun, Oct 05, 2014 at 01:24:22PM -0400, Joe Lawrence wrote: > Tidy up and use cond_resched_rcu_qs when calling cond_resched and > reporting potential quiescent state to RCU. > > Signed-off-by: Joe Lawrence <joe.lawrence@stratus.com>
Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> --- > kernel/workqueue.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/kernel/workqueue.c b/kernel/workqueue.c > index 345bec9..09b685d 100644 > --- a/kernel/workqueue.c > +++ b/kernel/workqueue.c > @@ -2046,8 +2046,7 @@ __acquires(&pool->lock) > * stop_machine. At the same time, report a quiescent RCU state so > * the same condition doesn't freeze RCU. > */ > - rcu_note_voluntary_context_switch(current); > - cond_resched(); > + cond_resched_rcu_qs(); > > spin_lock_irq(&pool->lock); > > -- > 1.7.10.4 >
| |