lkml.org 
[lkml]   [2014]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [RFC] arm:remove clear_thread_flag(TIF_UPROBE)
> From: Joe Perches [mailto:joe@perches.com]
> > > > @@ -591,10 +591,9 @@ do_work_pending(struct pt_regs *regs, unsigned
> int
> > > thread_flags, int syscall)
> > > > return restart;
> > > > }
> > > > syscall = 0;
> > > > - } else if (thread_flags & _TIF_UPROBE) {
> > > > - clear_thread_flag(TIF_UPROBE);
> > > > + } else if (thread_flags & _TIF_UPROBE)
> > > > uprobe_notify_resume(regs);
> > > > - } else {
> > > > + else {
> > > > clear_thread_flag(TIF_NOTIFY_RESUME);
> > > > tracehook_notify_resume(regs);
> > > > }
> > >
> > > Please keep the braces.
> >
> > mm.. could I know the reason ? :)
>
> Try read Documentation/CodingStyle
>
> Chapter 3: Placing Braces and Spaces
>
> use braces in both branches:
>
> if (condition) {
> do_this();
> do_that();
> } else {
> otherwise();
> }
>

Got it, I will resend one .
Thanks



\
 
 \ /
  Last update: 2014-10-31 09:21    [W:0.074 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site