Messages in this thread | | | Subject | Re: [PATCH 7/8] cdrom: cdrom: export sysctl code | From | Joe Perches <> | Date | Fri, 31 Oct 2014 15:12:34 -0700 |
| |
On Fri, 2014-10-31 at 22:48 +0100, Fabian Frederick wrote: > -Move all sysctl operations to cdrom_sysctl > -Remove static/add extern in cdrom.h for some variables > -Rename debug to cdrom_debug > -Fix some checkpatch warnings > -Update cdrom makefile accordingly. [] > diff --git a/include/linux/cdrom.h b/include/linux/cdrom.h [] > +extern bool cdrom_debug; > +extern bool autoclose; > +extern bool autoeject; > +extern bool lockdoor; > +extern bool check_media_type; > +extern bool mrw_format_restart; > +extern struct list_head cdrom_list; > +extern struct mutex cdrom_mutex;
I think these should be prefixed with "cdrom_"
| |