Messages in this thread | | | Date | Fri, 31 Oct 2014 13:55:33 -0700 | Subject | Re: [PATCH] x86, boot: add hex output for debugging | From | Kees Cook <> |
| |
On Fri, Oct 31, 2014 at 1:33 PM, <josh@joshtriplett.org> wrote: > On Fri, Oct 31, 2014 at 09:20:37AM -0700, Kees Cook wrote: >> This is useful for reporting various addresses or other values while >> debugging early boot. >> >> Signed-off-by: Kees Cook <keescook@chromium.org> > > You haven't provided any user of this function. I don't think this > should get merged without a caller (nor should an artificial caller be > added). What's your use case for adding this?
I'll fix that.
> Also, while I realize __putstr already has this problem, ideally all the > printing functions in this file should go in some separate source file > that gets omitted when !CONFIG_PRINTK (or possibly > !CONFIG_EARLY_PRINTK).
Hm, I don't agree: we need error_putstr, not just debug_putstr, and early_printk is just for serial console, where as __putstr works against the boot block's defined video area too, IIUC.
-Kees
-- Kees Cook Chrome OS Security
| |