Messages in this thread | | | Date | Fri, 31 Oct 2014 16:13:06 -0400 (EDT) | Subject | Re: [PATCH] net: ethtool: Return -EOPNOTSUPP if user space tries to read EEPROM with lengh 0 | From | David Miller <> |
| |
From: Andrew Lunn <andrew@lunn.ch> Date: Fri, 31 Oct 2014 04:56:35 +0100
> On Thu, Oct 30, 2014 at 08:50:15PM -0700, Guenter Roeck wrote: >> If a driver supports reading EEPROM but no EEPROM is installed in the system, >> the driver's get_eeprom_len function returns 0. ethtool will subsequently >> try to read that zero-length EEPROM anyway. If the driver does not support >> EEPROM access at all, this operation will return -EOPNOTSUPP. If the driver >> does support EEPROM access but no EEPROM is installed, the operation will >> return -EINVAL. Return -EOPNOTSUPP in both cases for consistency. >> >> Signed-off-by: Guenter Roeck <linux@roeck-us.net> > > root@dir665:~# ethtool -e lan4 > Cannot get EEPROM data: Operation not supported > > Tested-by: Andrew Lunn <andrew@lunn.ch>
Applied, thanks everyone.
| |