Messages in this thread | | | From | Dirk Brandewie <> | Date | Thu, 30 Oct 2014 23:15:09 -0700 | Subject | Re: [PATCH v2] cpufreq: allow powersave governor as the default without expert mode |
| |
On 10/30/2014 02:18 PM, Rafael J. Wysocki wrote: > On Thursday, October 16, 2014 07:37:11 AM James Geboski wrote: >> The intel_pstate driver only supports the performance and the powersave >> governors. With the performance governor ensuring the highest possible >> performance settings, userspace tools fail to make any lasting changes. >> In order to allow userspace tools to make modifications to the settings, >> the powersave governor must be in use. This makes having the powersave >> governor as the default convenient for systems where the intel_pstate >> driver is being employed. Having to enable expert mode in the kernel >> configuration is just a headache for such a trivial task. >> >> This patch applies to all kernel versions 2.6.38 or greater after the >> migration from CONFIG_EMBEDDED to CONFIG_EXPERT (6a108a14fa35). Most >> importantly, this applies to kernel versions 3.9 or greater when the >> intel_pstate driver was introduced. >> >> Signed-off-by: James Geboski <jgeboski@gmail.com> >> Acked-by: Viresh Kumar <viresh.kumar@linaro.org> > > Dirk, any objections?
No objection. > >> --- >> ChangeLog v2: >> - Acked-by: Viresh Kumar <viresh.kumar@linaro.org> >> --- >> drivers/cpufreq/Kconfig | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig >> index 3489f8f..73df7db 100644 >> --- a/drivers/cpufreq/Kconfig >> +++ b/drivers/cpufreq/Kconfig >> @@ -63,7 +63,6 @@ config CPU_FREQ_DEFAULT_GOV_PERFORMANCE >> >> config CPU_FREQ_DEFAULT_GOV_POWERSAVE >> bool "powersave" >> - depends on EXPERT >> select CPU_FREQ_GOV_POWERSAVE >> help >> Use the CPUFreq governor 'powersave' as default. This sets >> >
| |