Messages in this thread | | | Subject | Re: [PATCH 1/2] cfg80211: 802.11p OCB mode handling | From | Rostislav Lisovy <> | Date | Fri, 31 Oct 2014 16:12:40 +0100 |
| |
On Fri, 2014-10-31 at 14:13 +0100, Johannes Berg wrote: > On Thu, 2014-10-30 at 11:42 +0100, Rostislav Lisovy wrote: > > @@ -2093,6 +2102,7 @@ enum nl80211_iftype { > > NL80211_IFTYPE_P2P_CLIENT, > > NL80211_IFTYPE_P2P_GO, > > NL80211_IFTYPE_P2P_DEVICE, > > + NL80211_IFTYPE_OCB, > > This is causing a bunch of compiler warnings (warning: enumeration value > ‘NL80211_IFTYPE_OCB’ not handled in switch, e.g. in mac80211/iface.c) > which I think you should address in this patch. That'll mean that you > modify even mac80211 and potentially some drivers, but I think that's > the right thing to do in this patch since it's the one changing the API > to introduce the new value.
I was aware of the warnings but thought this is the chicken-egg problem which can't be solved properly. Fortunately there is no driver affected.
> I think there's one thing you forgot in this patch, namely > __cfg80211_leave() which you also need to make the __ version of the > leave function non-static for due to locking.
Correct. Adding to the next version of the patchset.
Thank you; Rostislav
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |