Messages in this thread | | | Date | Fri, 31 Oct 2014 11:03:34 +0100 | From | Daniel Mack <> | Subject | Re: kdbus: add header file |
| |
On 10/30/2014 01:03 PM, Arnd Bergmann wrote: > On Thursday 30 October 2014 12:52:58 Daniel Mack wrote:
>> Hmm, this is the header exported to userspace, so having enums in would >> make our lives easier, right? > > My point was that you never use the enum by type and the only place in > user space where it's referenced would be something like > > ret = ioctl(fd, KDBUS_CMD_BUS_MAKE, &make); > > In the debugger, you will see the source line here. If you trace into the > glibc ioctl function, you no longer know the type because that just > has an 'int'.
Alright - I changed that to #defines now.
Thanks, Daniel
| |