Messages in this thread | | | Subject | Re: iwlwifi: mvm: BACKPORT_WANT_DEV_COREDUMP? | From | Paul Bolle <> | Date | Fri, 31 Oct 2014 10:17:45 +0100 |
| |
On Fri, 2014-10-31 at 10:08 +0100, Johannes Berg wrote: > On Fri, 2014-10-31 at 10:06 +0100, Paul Bolle wrote: > > Perhaps you could also look into somehow guarding the call of > > dev_coredumpm(), that this commit added, with checks for > > CONFIG_DEV_COREDUMP. See, I had a quick look at all this and selecting > > WANT_DEV_COREDUMP might not be enough, because DISABLE_DEV_COREDUMP can > > still, well, disable DEV_COREDUMP. Or am I misreading the Kconfig > > symbols that regulate DEV_COREDUMP? > > No, you're correctly reading that. However, the devcoredump header file > provides simple functions in this case. That means there's some extra > work (allocating and filling the buffer just to free it immediately) but > it simplifies the code.
I see. More than a quick look was required here. Thanks for explaining this!
Paul Bolle
| |