lkml.org 
[lkml]   [2014]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 04/14] perf tools: Add kbuild support into Makefile.kbuild
On Thu, Oct 30, 2014 at 12:05:07AM +0100, Alexis Berlemont wrote:

SNIP

> > > tools/perf/util/Kbuild | 126 ++++++
> > > tools/perf/util/PERF-VERSION-GEN | 4 +
> > > tools/perf/util/generate-cmdlist.sh | 8 +-
> > > tools/perf/util/scripting-engines/Kbuild | 11 +
> > > tools/perf/util/setup.py | 8 +-
> >
> > so this patch took the perf Makefile (at that time) and changed it to
> > use the kbuild.. but since that time the Makefile.perf came and many
> > other changes, which need to be reflected in Makefile.kbuild
> >
> > I need to revisit the logic and split the change into more incremental
> > patches (the patchset is too big)
> >
> > I can redo patches 2,3,4 and get back to you, sounds ok?
>
> Of course.
>
> Which changes in Makefile.perf do you have in mind ? I thought that
> Makefile.kbuild was just supposed to build the few extra dependencies
> (libtraceevent, etc.). I thought that I updated your original patch
> accordingly with the changes before and after the add of
> Makefile.perf.

hm, I just stumbled on QUIET_* stuff definitions in Makefile.kbuild,
(which got moved into scripts some time ago) and assumed this was
the case for the rest of the file ;-)

jirka


\
 
 \ /
  Last update: 2014-10-31 09:41    [W:0.952 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site