lkml.org 
[lkml]   [2014]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v5 4/4] crypto: Add Allwinner Security System crypto accelerator
    On Fri, Oct 31, 2014 at 09:13:23AM +0100, Maxime Ripard wrote:
    >
    > I don't understand here. Why would other drivers *not* being affected?
    >
    > If the scatter list passed by AF_ALG can be in highmem, I guess it's
    > the case for every driver out there. Almost every kernel code I've
    > seen so far makes the assumption that the memory it has is mapped and
    > accessible.
    >
    > Somehow, it's the driver's fault now, and not the part of kernel that
    > actually does the allocation?

    If you are implementing a crypto driver that is meant to handle
    requests from the crypto API then yes you need to handle highmem.

    As I said if enough drivers are unable to address highmem and
    require copying/software fallbacks then we could provide this
    through the API and the driver would then only need to declare
    its lack of highmem support or use a helper.

    Cheers,
    --
    Email: Herbert Xu <herbert@gondor.apana.org.au>
    Home Page: http://gondor.apana.org.au/~herbert/
    PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


    \
     
     \ /
      Last update: 2014-10-31 09:41    [W:4.287 / U:0.416 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site