Messages in this thread | | | Date | Thu, 30 Oct 2014 20:29:21 +0000 | From | Ian Abbott <> | Subject | Re: [PATCH 5/7] staging: comedi: don't allow write() on async command set up for "read" |
| |
On 30/10/14 18:07, Hartley Sweeten wrote: > On Thursday, October 30, 2014 5:43 AM, Ian Abbott wrote: [snip] >> add_wait_queue(&async->wait_head, &wait); >> on_wait_queue = true; >> @@ -2146,6 +2150,10 @@ static ssize_t comedi_write(struct file *file, const char __user *buf, >> retval = -EACCES; >> break; >> } >> + if (!(async->cmd.flags & CMDF_WRITE)) { >> + retval = -EINVAL; >> + break; >> + } > > Same question as with PATCH 4/7. > > Is this test needed in the while () loop. Also, are the s->busy tests needed here?
Yes, for similar reasons.
-- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=- -=( Web: http://www.mev.co.uk/ )=-
| |