Messages in this thread | | | From | Bjorn Helgaas <> | Date | Thu, 30 Oct 2014 13:27:15 -0600 | Subject | Re: [PATCH] PCI: fix sriov enabling with virtual bus |
| |
On Thu, Oct 30, 2014 at 12:57 PM, Yinghai Lu <yinghai@kernel.org> wrote: > On Thu, Oct 30, 2014 at 10:09 AM, Bjorn Helgaas <bhelgaas@google.com> wrote:
>>> Fixing: commit 6cd33649fa83 ("PCI: Add pci_configure_device() during enumeration") >> >> Thanks for including this, but why not use the same format everybody else >> does: >> >> Fixes: 6cd33649fa83 ("PCI: Add pci_configure_device() during enumeration") > > will do that later. Is that formalized ?
I don't know that it's formalized, but it seems to be a common convention, and using "Fixing: commit" instead of "Fixes:" doesn't seem to add value. I guess I must spend more time reading git logs than most people :)
> checkpatch.pl only need 12 commit code, and (" ..") format.
| |