Messages in this thread | | | Date | Thu, 30 Oct 2014 12:17:10 -0400 (EDT) | Subject | Re: net: fec: fix regression on i.MX28 introduced by rx_copybreak support | From | David Miller <> |
| |
From: Lothar Waßmann <LW@KARO-electronics.de> Date: Thu, 30 Oct 2014 07:51:04 +0100
>> Also, I don't thnk your DIV_ROUND_UP() eliminate for the loop >> in swap_buffer() is valid. The whole point is that the current >> code handles buffers which have a length which is not a multiple >> of 4 properly, after your change it will no longer do so. >> > Do you really think so?
Yes, because you're rounding down so you'll miss the final partial word (if any). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |