Messages in this thread | | | Date | Thu, 30 Oct 2014 16:00:39 +0100 | Subject | Re: [PATCH] gpio: msm-v1: Fix typo in function argument | From | Linus Walleij <> |
| |
On Fri, Oct 24, 2014 at 4:29 PM, Daniel Thompson <daniel.thompson@linaro.org> wrote:
> irq_set_irq_wake() treats its second argument as a boolean. It is much > easier to read code when constant booleans are either 0 or 1! > > This particular line of code distracted me somewhat when I was doing a bit of > work in a code browser since it (spuriously) got me worried that I had > misunderstood how irq_set_irq_wake() worked. > > Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Alexandre Courbot <gnurou@gmail.com>
Patch applied with Alexandre's Review tag.
Yours, Linus Walleij
| |