Messages in this thread | | | From | Jingoo Han <> | Subject | Re: [PATCH] backlight: use of_find_backlight_by_node stub when backlight class disabled | Date | Thu, 30 Oct 2014 13:44:16 +0900 |
| |
On Wednesday, October 29, 2014 9:20 AM, Heiko Stübner wrote: > > Drivers may want to search for an optional backlight even when the backlight > class is disabled. In this case the linker would miss the function referenced > in the backlight header. > > Therefore use the stub function also when the backlight class is disabled. > > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
of_find_backlight_by_node()is defined at ./drivers/video/backlight/backlight.c file. Also, this file can be built when CONFIG_BACKLIGHT_CLASS_DEVICE=y. So, in order to prevent the possible build error, this patch looks good.
Acked-by: Jingoo Han <jg1.han@samsung.com>
Best regards, Jingoo Han
> --- > include/linux/backlight.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/backlight.h b/include/linux/backlight.h > index adb14a8..d9cb644 100644 > --- a/include/linux/backlight.h > +++ b/include/linux/backlight.h > @@ -157,7 +157,7 @@ struct generic_bl_info { > void (*kick_battery)(void); > }; > > -#ifdef CONFIG_OF > +#if defined(CONFIG_OF) && defined(CONFIG_BACKLIGHT_CLASS_DEVICE) > struct backlight_device *of_find_backlight_by_node(struct device_node *node); > #else > static inline struct backlight_device * > -- > 2.0.1
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |