Messages in this thread Patch in this message | | | From | Pramod Gurav <> | Subject | [PATCH] mfd: db8500-prcmu: check return of devm_ioremap for error | Date | Thu, 30 Oct 2014 14:51:35 +0530 |
| |
Error check around return value of devm_ioremap is missing. Add the same to avoid NULL pointer dereference.
Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Samuel Ortiz <sameo@linux.intel.com> Cc: Lee Jones <lee.jones@linaro.org> Signed-off-by: Pramod Gurav <pramod.gurav@smartplayin.com> --- drivers/mfd/db8500-prcmu.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c index 193cf16..89ae8bf 100644 --- a/drivers/mfd/db8500-prcmu.c +++ b/drivers/mfd/db8500-prcmu.c @@ -3167,6 +3167,11 @@ static int db8500_prcmu_probe(struct platform_device *pdev) } tcdm_base = devm_ioremap(&pdev->dev, res->start, resource_size(res)); + if (!tcdm_base) { + dev_err(&pdev->dev, + "failed to ioremap prcmu-tcdm register memory\n"); + return -ENOENT; + } /* Clean up the mailbox interrupts after pre-kernel code. */ writel(ALL_MBOX_BITS, PRCM_ARM_IT1_CLR); -- 1.7.9.5
| |