Messages in this thread | | | Subject | Re: [PATCH] UBI: vtbl: Use ubi_eba_atomic_leb_change() | From | Artem Bityutskiy <> | Date | Thu, 30 Oct 2014 10:55:49 +0200 |
| |
On Sat, 2014-10-25 at 19:43 +0200, Richard Weinberger wrote: > This is more a cosmetic change than a fix. > By using ubi_eba_atomic_leb_change() > we can guarantee that the first VTBL record is always > correct and we don't really need the second one anymore. > But we have to keep the second one to not break anything. > > Signed-off-by: Richard Weinberger <richard@nod.at>
Yeah, this atomic change stuff was added later, and we had not envisioned originally. Your patch adds robustness, but makes volume creation slower, which is probably not a problem.
I've added a small comment and pushed it, thanks!
Artem
| |