lkml.org 
[lkml]   [2014]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.14 101/238] USB: EHCI: unlink QHs even after the controller has stopped
    Date
    3.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Alan Stern <stern@rowland.harvard.edu>

    commit 7312b5ddd47fee2356baa78c5516ef8e04eed452 upstream.

    Old code in ehci-hcd tries to expedite disabling endpoints after the
    controller has stopped, by destroying the endpoint's associated QH
    without first unlinking the QH. This was necessary back when the
    driver wasn't so careful about keeping track of the controller's
    state.

    But now we are careful about it, and the driver knows that when the
    controller isn't running, no unlinking delay is needed. Furthermore,
    skipping the unlink step will trigger a BUG() in qh_destroy() when the
    preceding QH is released, because the link pointer will be non-NULL.

    Removing the lines that skip the unlinking step and go directly to
    QH_STATE_IDLE fixes the problem.

    Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
    Reported-by: Joe Lawrence <joe.lawrence@stratus.com>
    Tested-by: Joe Lawrence <joe.lawrence@stratus.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/host/ehci-hcd.c | 2 --
    1 file changed, 2 deletions(-)

    --- a/drivers/usb/host/ehci-hcd.c
    +++ b/drivers/usb/host/ehci-hcd.c
    @@ -965,8 +965,6 @@ rescan:
    }

    qh->exception = 1;
    - if (ehci->rh_state < EHCI_RH_RUNNING)
    - qh->qh_state = QH_STATE_IDLE;
    switch (qh->qh_state) {
    case QH_STATE_LINKED:
    WARN_ON(!list_empty(&qh->qtd_list));



    \
     
     \ /
      Last update: 2014-10-04 02:21    [W:4.065 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site