lkml.org 
[lkml]   [2014]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.14 109/238] spi: dw-pci: fix bug when regs left uninitialized
    Date
    3.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

    commit c9d5d6fe168fd45a4dfdd0116affe708789b4702 upstream.

    The commit 04f421e7 "spi: dw: use managed resources" changes drivers to use
    managed functions, but seems wasn't properly tested in PCI case. The regs field
    of struct dw_spi left uninitialized. Thus, kernel crashes when tries to access
    to the SPI controller registers. This patch fixes the issue.

    Fixes: 04f421e7 (spi: dw: use managed resources)
    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    Signed-off-by: Mark Brown <broonie@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/spi/spi-dw-pci.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/spi/spi-dw-pci.c
    +++ b/drivers/spi/spi-dw-pci.c
    @@ -62,6 +62,8 @@ static int spi_pci_probe(struct pci_dev
    if (ret)
    return ret;

    + dws->regs = pcim_iomap_table(pdev)[pci_bar];
    +
    dws->bus_num = 0;
    dws->num_cs = 4;
    dws->irq = pdev->irq;



    \
     
     \ /
      Last update: 2014-10-04 02:21    [W:6.119 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site