Messages in this thread | | | Date | Fri, 03 Oct 2014 11:47:59 +0200 | From | Hans de Goede <> | Subject | Re: [PATCH 1/3] input: alps: Reset mouse before identifying it |
| |
Hi,
Thanks for working on this!
On 10/03/2014 11:43 AM, Pali Rohár wrote: > On some systems after starting computer function alps_identify() does not detect > dual ALPS touchpad+trackstick device correctly and detect only touchpad. > > Resetting ALPS device before identifiying it fixing this problem and both parts > touchpad and trackstick are detected. > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com> > Tested-by: Pali Rohár <pali.rohar@gmail.com>
Looks good and seems sensible:
Acked-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> --- > drivers/input/mouse/alps.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c > index 35a49bf..1bd5aa1 100644 > --- a/drivers/input/mouse/alps.c > +++ b/drivers/input/mouse/alps.c > @@ -2403,6 +2403,8 @@ int alps_detect(struct psmouse *psmouse, bool set_properties) > { > struct alps_data dummy; > > + psmouse_reset(psmouse); > + > if (alps_identify(psmouse, &dummy) < 0) > return -1; > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |