lkml.org 
[lkml]   [2014]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.16 336/357] md/raid1: intialise start_next_window for READ case to avoid hang
    Date
    3.16-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: NeilBrown <neilb@suse.de>

    commit f0cc9a057151892b885be21a1d19b0185568281d upstream.

    r1_bio->start_next_window is not initialised in the READ
    case, so allow_barrier may incorrectly decrement
    conf->current_window_requests
    which can cause raise_barrier() to block forever.

    Fixes: 79ef3a8aa1cb1523cc231c9a90a278333c21f761
    Reported-by: Brassow Jonathan <jbrassow@redhat.com>
    Signed-off-by: NeilBrown <neilb@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/md/raid1.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/md/raid1.c
    +++ b/drivers/md/raid1.c
    @@ -1185,6 +1185,7 @@ read_again:
    atomic_read(&bitmap->behind_writes) == 0);
    }
    r1_bio->read_disk = rdisk;
    + r1_bio->start_next_window = 0;

    read_bio = bio_clone_mddev(bio, GFP_NOIO, mddev);
    bio_trim(read_bio, r1_bio->sector - bio->bi_iter.bi_sector,



    \
     
     \ /
      Last update: 2014-10-04 02:01    [W:4.030 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site