| From | Greg Kroah-Hartman <> | Subject | [PATCH 3.14 147/238] target: Fix inverted logic in SE_DEV_ALUA_SUPPORT_STATE_STORE | Date | Fri, 3 Oct 2014 14:31:02 -0700 |
| |
3.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Sebastian Herbszt <herbszt@gmx.de>
commit 1f0b030c45c781f9fe568e5e2a813d6c8567a051 upstream.
Fix inverted logic in SE_DEV_ALUA_SUPPORT_STATE_STORE for setting the supported ALUA access states via configfs, originally introduced in commit b0a382c5.
A value of 1 should enable the support, not disable it.
Signed-off-by: Sebastian Herbszt <herbszt@gmx.de> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
--- drivers/target/target_core_configfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/target/target_core_configfs.c +++ b/drivers/target/target_core_configfs.c @@ -2359,7 +2359,7 @@ static ssize_t target_core_alua_tg_pt_gp pr_err("Invalid value '%ld', must be '0' or '1'\n", tmp); \ return -EINVAL; \ } \ - if (!tmp) \ + if (tmp) \ t->_var |= _bit; \ else \ t->_var &= ~_bit; \
|