lkml.org 
[lkml]   [2014]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.14 137/238] iio: hid_sensor_hub: Fix indio_dev->trig assignment
    Date
    3.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>

    commit 55a6f9ddfdea0d2d343cd1b39baf8aa752664b6e upstream.

    This can result in wrong reference count for trigger device, call
    iio_trigger_get to increment reference.
    Refer to http://www.spinics.net/lists/linux-iio/msg13669.html for discussion
    with Jonathan.

    Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
    Signed-off-by: Jonathan Cameron <jic23@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/iio/common/hid-sensors/hid-sensor-trigger.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
    +++ b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
    @@ -99,7 +99,8 @@ int hid_sensor_setup_trigger(struct iio_
    dev_err(&indio_dev->dev, "Trigger Register Failed\n");
    goto error_free_trig;
    }
    - indio_dev->trig = attrb->trigger = trig;
    + attrb->trigger = trig;
    + indio_dev->trig = iio_trigger_get(trig);

    return ret;




    \
     
     \ /
      Last update: 2014-10-04 02:01    [W:2.811 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site