lkml.org 
[lkml]   [2014]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 087/143] Target/iser: Dont put isert_conn inside disconnected handler
    Date
    3.10-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Sagi Grimberg <sagig@mellanox.com>

    commit 0fc4ea701fcf5bc51ace4e288af5be741465f776 upstream.

    disconnected_handler is invoked on several CM events (such
    as DISCONNECTED, DEVICE_REMOVAL, TIMEWAIT_EXIT...). Since
    multiple events can occur while before isert_free_conn is
    invoked, we might put all isert_conn references and free
    the connection too early.

    Signed-off-by: Sagi Grimberg <sagig@mellanox.com>
    Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/infiniband/ulp/isert/ib_isert.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/infiniband/ulp/isert/ib_isert.c
    +++ b/drivers/infiniband/ulp/isert/ib_isert.c
    @@ -583,7 +583,6 @@ isert_disconnect_work(struct work_struct

    wake_up:
    complete(&isert_conn->conn_wait);
    - isert_put_conn(isert_conn);
    }

    static void
    @@ -2266,6 +2265,7 @@ static void isert_wait_conn(struct iscsi
    wait_for_completion(&isert_conn->conn_wait_comp_err);

    wait_for_completion(&isert_conn->conn_wait);
    + isert_put_conn(isert_conn);
    }

    static void isert_free_conn(struct iscsi_conn *conn)



    \
     
     \ /
      Last update: 2014-10-04 01:21    [W:3.253 / U:1.832 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site