lkml.org 
[lkml]   [2014]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 081/143] iio: meter: ade7758: Fix indio_dev->trig assignment
    Date
    3.10-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>

    commit 0495081179212b758775df752e657ea71dcae020 upstream.

    This can result in wrong reference count for trigger device, call
    iio_trigger_get to increment reference.
    Refer to http://www.spinics.net/lists/linux-iio/msg13669.html for discussion
    with Jonathan.

    Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
    Acked-by: Lars-Peter Clausen <lars@metafoo.de>
    Signed-off-by: Jonathan Cameron <jic23@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/staging/iio/meter/ade7758_trigger.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/staging/iio/meter/ade7758_trigger.c
    +++ b/drivers/staging/iio/meter/ade7758_trigger.c
    @@ -85,7 +85,7 @@ int ade7758_probe_trigger(struct iio_dev
    ret = iio_trigger_register(st->trig);

    /* select default trigger */
    - indio_dev->trig = st->trig;
    + indio_dev->trig = iio_trigger_get(st->trig);
    if (ret)
    goto error_free_irq;




    \
     
     \ /
      Last update: 2014-10-04 01:21    [W:3.480 / U:0.452 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site