lkml.org 
[lkml]   [2014]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 111/143] usb: dwc3: core: fix ordering for PHY suspend
    Date
    3.10-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Felipe Balbi <balbi@ti.com>

    commit dc99f16f076559235c92d3eb66d03d1310faea08 upstream.

    We can't suspend the PHYs before dwc3_core_exit_mode()
    has been called, that's because the host and/or device
    sides might still need to communicate with the far end
    link partner.

    Fixes: 8ba007a (usb: dwc3: core: enable the USB2 and USB3 phy in probe)
    Suggested-by: Alan Stern <stern@rowland.harvard.edu>
    Signed-off-by: Felipe Balbi <balbi@ti.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/dwc3/core.c | 7 ++++---
    1 file changed, 4 insertions(+), 3 deletions(-)

    --- a/drivers/usb/dwc3/core.c
    +++ b/drivers/usb/dwc3/core.c
    @@ -603,9 +603,6 @@ static int dwc3_remove(struct platform_d
    {
    struct dwc3 *dwc = platform_get_drvdata(pdev);

    - usb_phy_set_suspend(dwc->usb2_phy, 1);
    - usb_phy_set_suspend(dwc->usb3_phy, 1);
    -
    dwc3_debugfs_exit(dwc);

    switch (dwc->mode) {
    @@ -626,6 +623,10 @@ static int dwc3_remove(struct platform_d

    dwc3_event_buffers_cleanup(dwc);
    dwc3_free_event_buffers(dwc);
    +
    + usb_phy_set_suspend(dwc->usb2_phy, 1);
    + usb_phy_set_suspend(dwc->usb3_phy, 1);
    +
    dwc3_core_exit(dwc);

    pm_runtime_put_sync(&pdev->dev);



    \
     
     \ /
      Last update: 2014-10-04 01:01    [W:4.253 / U:0.420 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site