lkml.org 
[lkml]   [2014]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 128/143] ipvs: avoid netns exit crash on ip_vs_conn_drop_conntrack
    Date
    3.10-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Julian Anastasov <ja@ssi.bg>

    commit 2627b7e15c5064ddd5e578e4efd948d48d531a3f upstream.

    commit 8f4e0a18682d91 ("IPVS netns exit causes crash in conntrack")
    added second ip_vs_conn_drop_conntrack call instead of just adding
    the needed check. As result, the first call still can cause
    crash on netns exit. Remove it.

    Signed-off-by: Julian Anastasov <ja@ssi.bg>
    Signed-off-by: Hans Schillstrom <hans@schillstrom.com>
    Signed-off-by: Simon Horman <horms@verge.net.au>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    net/netfilter/ipvs/ip_vs_conn.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/net/netfilter/ipvs/ip_vs_conn.c
    +++ b/net/netfilter/ipvs/ip_vs_conn.c
    @@ -797,7 +797,6 @@ static void ip_vs_conn_expire(unsigned l
    ip_vs_control_del(cp);

    if (cp->flags & IP_VS_CONN_F_NFCT) {
    - ip_vs_conn_drop_conntrack(cp);
    /* Do not access conntracks during subsys cleanup
    * because nf_conntrack_find_get can not be used after
    * conntrack cleanup for the net.



    \
     
     \ /
      Last update: 2014-10-04 01:01    [W:4.114 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site