| From | Greg Kroah-Hartman <> | Subject | [PATCH 3.16 206/357] cgroup: reject cgroup names with \n | Date | Fri, 3 Oct 2014 14:29:52 -0700 |
| |
3.16-stable review patch. If anyone has any objections, please let me know.
------------------
From: Alban Crequy <alban.crequy@collabora.co.uk>
commit 71b1fb5c4473a5b1e601d41b109bdfe001ec82e0 upstream.
/proc/<pid>/cgroup contains one cgroup path on each line. If cgroup names are allowed to contain "\n", applications cannot parse /proc/<pid>/cgroup safely.
Signed-off-by: Alban Crequy <alban.crequy@collabora.co.uk> Signed-off-by: Tejun Heo <tj@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
--- kernel/cgroup.c | 5 +++++ 1 file changed, 5 insertions(+)
--- a/kernel/cgroup.c +++ b/kernel/cgroup.c @@ -4393,6 +4393,11 @@ static int cgroup_mkdir(struct kernfs_no struct kernfs_node *kn; int ssid, ret; + /* Do not accept '\n' to prevent making /proc/<pid>/cgroup unparsable. + */ + if (strchr(name, '\n')) + return -EINVAL; + parent = cgroup_kn_lock_live(parent_kn); if (!parent) return -ENODEV;
|