lkml.org 
[lkml]   [2014]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5] Combine ifs into one where possible to avoid unnecessary indentation level increase
On Fri, Oct 03, 2014 at 11:27:04PM +0300, Giedrius Statkevicius wrote:
> From: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
>
> Join together chained if's where possible to lower the indentation level.
>
> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>

Your subject is "odd", in that it doesn't say what part of the kernel it
is for. Look at the kernel git logs, it should give you an idea of how
to format things properly.

Also, you don't have to have such a long subject:, try to keep it short,
and then be verbose in the changelog body.

Can you fix up all of these 5 and resend?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-10-03 23:01    [W:0.052 / U:0.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site