lkml.org 
[lkml]   [2014]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] mtd: ubi: Extend UBI layer debug/messaging capabilities
From
On 3 October 2014 17:27, Artem Bityutskiy <dedekind1@gmail.com> wrote:
> Yes, I guess a single patch is indeed OK. I have few nit-picks, though.
>
> On Tue, 2014-09-30 at 18:13 +0300, Tanya Brokhman wrote:
>> - ubi_err("'ubi_io_read_ec_hdr()' returned unknown code %d", err);
>> + ubi_err(ubi,
>> + "'ubi_io_read_ec_hdr()' returned unknown code %d", err);
>> return -EINVAL;
>
> I think it is fine if the line is long in these cases, let's keep the
> message on the same line, this split does not contribute to better
> readability, quite the opposite, in my opinion.
>
> One line:
> ubi_err(ubi, "long line")
>
> Multiple lines:
> ubi_err(ubi, "long line,
> parameters)

You should discuss that with checkpatch team, because ARAIR it will
complain about "long line" with any other parameter in the same line.


\
 
 \ /
  Last update: 2014-10-03 18:21    [W:0.223 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site