Messages in this thread | | | Date | Fri, 03 Oct 2014 08:21:29 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH v5 1/4] hwmon: ltc2978: device tree bindings documentation |
| |
On 10/03/2014 06:05 AM, Mark Rutland wrote: > On Fri, Oct 03, 2014 at 02:03:23PM +0100, Guenter Roeck wrote: >> On 10/03/2014 05:27 AM, Mark Rutland wrote: >>> On Thu, Oct 02, 2014 at 07:37:48PM +0100, atull@opensource.altera.com wrote: >>>> From: Alan Tull <atull@opensource.altera.com> >>>> >>>> Add device tree bindings documentation for ltc2978. >>>> >>>> Signed-off-by: Alan Tull <atull@opensource.altera.com> >>>> --- >>>> v2: clean whitespace >>>> --- >>>> .../devicetree/bindings/hwmon/ltc2978.txt | 41 ++++++++++++++++++++ >>>> 1 file changed, 41 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/hwmon/ltc2978.txt >>>> >>>> diff --git a/Documentation/devicetree/bindings/hwmon/ltc2978.txt b/Documentation/devicetree/bindings/hwmon/ltc2978.txt >>>> new file mode 100644 >>>> index 0000000..b2d9c4d >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/hwmon/ltc2978.txt >>>> @@ -0,0 +1,41 @@ >>>> +ltc2978 >>>> + >>>> +Required properties: >>>> + - compatible: one of: ltc2974, ltc2977, ltc2978, ltc3880, ltc3883, ltm4676 >>> >>> Could we please format this like: >>> >>> - compatible: should contain one of: >>> * "ltc2974" >>> * "ltc2977" >>> * "ltc2978" >>> * "ltc3880" >>> * "ltc3883" >>> * "ltm4676" >>> >>> Given the file name, are these all variants of ltc2978? >>> >> >> All the chips supported by the ltc2978 driver. Some are variants >> of the ltc2978, some have different functionality. > > Ok. > >> >> [ should those be "linear,ltc2974" and so on ? ] > > Good point; yes they should. That will need a vendor-prefixes.txt > addition. > Actually, turns out there already is one, only it is not immediately obvious: lltc for "Linear Technology Corporation".
Guenter
| |