Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 2/2] net: spider_net: avoid using signed char for bitops | Date | Fri, 03 Oct 2014 17:15:05 +0200 |
| |
On Friday 03 October 2014 17:01:56 Antoine Tenart wrote: > Signedness bugs may occur when using signed char for bitops, > depending on if the highest bit is ever used. > > Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> >
It's probably worth mentioning here that this cannot happen in this driver because it's only used in one powerpc-specific chip, and 'char' is always 'unsigned' on powerpc.
Arnd
| |