Messages in this thread | | | Date | Fri, 03 Oct 2014 15:07:14 +0200 | From | Nicolas Dichtel <> | Subject | Re: [RFC PATCH linux 2/2] fs/proc: use a hash table for the directory entries |
| |
Le 03/10/2014 12:55, Alexey Dobriyan a écrit : > On Thu, Oct 2, 2014 at 6:25 PM, Nicolas Dichtel > <nicolas.dichtel@6wind.com> wrote: >> --- a/fs/proc/generic.c >> +++ b/fs/proc/generic.c >> @@ -81,10 +81,13 @@ static int __xlate_proc_name(const char *name, struct proc_dir_entry **ret, > >> + if (!S_ISDIR(de->mode)) >> + return -EINVAL; > > There are way too many S_ISDIR checks. > In lookup and readdir, it is guaranteed that PDE is directory. > > I'd say all of them aren't needed because non-directories have > ->subdir = NULL and > directories have ->subdir != NULL which transforms into hashtable or > rbtree or whatever, > so you only need to guarantee only directories appear where they are > expected and > fearlessly use your new data structure traversing directories. To be honest, they was put during the debug stage and I hesitated to remove them at the end. I will remove them!
Thank you, Nicolas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |