Messages in this thread | | | Date | Fri, 03 Oct 2014 21:55:08 +0900 | From | Masami Hiramatsu <> | Subject | Re: [PATCH v2 3/5] perf/sdt: Show SDT cache contents |
| |
(2014/10/01 11:48), Hemant Kumar wrote: > @@ -35,10 +45,13 @@ int cmd_sdt_cache(int argc, const char **argv, const char *prefix __maybe_unused > OPT_CALLBACK('a', "add", NULL, "filename", > "add SDT events from a file.", > opt_add_sdt_events), > + OPT_CALLBACK_NOOPT('s', "dump", NULL, "show SDT events", > + "Read SDT events from cache and display.", > + opt_show_sdt_events),
Just one note here. -s and --dump are a bit odd. how about using -D for short ops?
Thank you,
-- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Research Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com
| |