lkml.org 
[lkml]   [2014]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH RESEND] x86: Reject x32 executables if x32 ABI not supported
From
Date
Can one of you please respond to this patch?

Ben.

On Sun, 2014-09-07 at 21:05 +0100, Ben Hutchings wrote:
> It is currently possible to execve() an x32 executable on an x86_64
> kernel that has only ia32 compat enabled. However all its syscalls
> will fail, even _exit(). This usually causes it to segfault.
>
> Change the ELF compat architecture check so that x32 executables are
> rejected if we don't support the x32 ABI.
>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
> arch/x86/include/asm/elf.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/include/asm/elf.h b/arch/x86/include/asm/elf.h
> index 1a055c8..ca3347a 100644
> --- a/arch/x86/include/asm/elf.h
> +++ b/arch/x86/include/asm/elf.h
> @@ -160,8 +160,9 @@ do { \
> #define elf_check_arch(x) \
> ((x)->e_machine == EM_X86_64)
>
> -#define compat_elf_check_arch(x) \
> - (elf_check_arch_ia32(x) || (x)->e_machine == EM_X86_64)
> +#define compat_elf_check_arch(x) \
> + (elf_check_arch_ia32(x) || \
> + (IS_ENABLED(CONFIG_X86_X32_ABI) && (x)->e_machine == EM_X86_64))
>
> #if __USER32_DS != __USER_DS
> # error "The following code assumes __USER32_DS == __USER_DS"
>
>

--
Ben Hutchings
One of the nice things about standards is that there are so many of them.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-10-04 04:21    [W:0.075 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site